On Wed, 6 Sep 2023 13:07:10 GMT, Doug Lea <[email protected]> wrote:
>> Addresses Jdk 8288899 : java/util/concurrent/ExecutorService/CloseTest.java
>> failed with "InterruptedException: sleep interrupted" and related issues.
>>
>> This is a major ForkJoin update (and hard to review -- sorry) that finally
>> addresses incompatibilities between ExecutorService and ForkJoinPool (which
>> claims to implement it), with the goal of avoiding continuing bug reports
>> and incompatibilities. Doing this required reworking internal control to use
>> phaser/seqlock-style versioning schemes (affecting nearly every method) that
>> ensure consistent data structures and actions without requiring global
>> synchronization or locking on every task execution that would massively
>> degrade performance. The previous lack of a solution to this was the main
>> reason for these incompatibilities.
>
> Doug Lea has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Allow ThreadGroup access in tck tests
test/jdk/java/util/concurrent/tck/JSR166TestCase.java line 1687:
> 1685: thread.join(timeoutMillis);
> 1686: break;
> 1687: } catch (InterruptedException ignore) {
@DougLea Shouldn't this deduct the wait-time for the next join if it gets
interrupted? 🤔
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/14301#discussion_r1318289951
