On Thu, 7 Sep 2023 08:46:09 GMT, Viktor Klang <[email protected]> wrote:
>> Doug Lea has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Allow ThreadGroup access in tck tests
>
> test/jdk/java/util/concurrent/tck/JSR166TestCase.java line 1687:
>
>> 1685: thread.join(timeoutMillis);
>> 1686: break;
>> 1687: } catch (InterruptedException ignore) {
>
> @DougLea Shouldn't this deduct the wait-time for the next join if it gets
> interrupted? 🤔
Ordinarily yes, but here it shouldn't matter: the timeout is just an arbitrary
value to catch stuck tests, and sometimes waiting twice as long because of an
interrupt is OK.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/14301#discussion_r1319856505
