On Wed, 20 Sep 2023 16:12:36 GMT, Naoto Sato <na...@openjdk.org> wrote:
>> Fixing a test case that fails in some time zones. Making sure the test is >> run in `UTC` zone will fix the issue. Confirmed the fix by manually setting >> machine's time zone to Europe/Dublin. > > Naoto Sato has updated the pull request incrementally with one additional > commit since the last revision: > > Reflects review comments Thanks, Jai. Since `assertCurrentDate()` is apart from the actual JVM invoking test method `testEmptySysPropValue()`, I thought it would be safer to use UTC in all test cases so that if someone calls `assertCurrentDate()` in other test methods, the test wouldn't break. But you are right that they are not needed in other locations right now. I removed those locations and instead added some instructions in `assertCurrentDate()` for future proof. ------------- PR Comment: https://git.openjdk.org/jdk/pull/15829#issuecomment-1728050059
