On Thu, 21 Sep 2023 07:17:43 GMT, Alan Bateman <al...@openjdk.org> wrote:
>> Naoto Sato has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Reflects review comments > > test/jdk/java/util/Properties/StoreReproducibilityTest.java line 137: > >> 135: final Path tmpFile = Files.createTempFile("8231640", >> ".props"); >> 136: storedFiles.add(tmpFile); >> 137: final ProcessBuilder processBuilder = >> ProcessTools.createJavaProcessBuilder( > > ProcessTools.createJavaProcessBuilder came up in another PR because it > doesn't prepend the VM and java opts. As all usages of PB are being updated > in this test then it makes me wonder if it should be changed to use > createTestJvm while you're there. Actually, I was limiting the change to a single JVM invocation 😄 But yes, it is appropriate to replace the invocation. Replaced them all. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/15829#discussion_r1333464550