On Mon, 2 Oct 2023 14:45:52 GMT, Maurizio Cimadamore <mcimadam...@openjdk.org> wrote:
>> test/langtools/tools/javac/7166455/CheckACC_STRICTFlagOnclinitTest.java line >> 107: >> >>> 105: } >>> 106: >>> 107: // this version of the code can be used when ClassFile API in not in a >>> preview >> >> Do you want to keep these commented lines? I'm fine (as it seems like you >> saved the code that was there before, for future reference). I'm just asking >> as this is a biggie PR, in case something went amiss. > > That said, if tests with such usages are not many, we could also consider > adding enable-preview to the tests, and just use the new API. Yes, that is proposed temporary solution to do not loose already converted code while ClassFile API is in preview. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/15706#discussion_r1342824044
