On Thu, 16 Nov 2023 17:08:58 GMT, Naoto Sato <na...@openjdk.org> wrote:
>> Andrey Turbanov has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8316557: Make fields final in 'sun.util' package
>>
>> rename 'firstDay' to 'firstDays' to match 'minDays' naming
>
> src/java.base/share/classes/sun/util/cldr/CLDRCalendarDataProviderImpl.java
> line 48:
>
>> 46: public class CLDRCalendarDataProviderImpl extends
>> CalendarDataProviderImpl {
>> 47:
>> 48: private static final Map<String, Integer> firstDays = new
>> ConcurrentHashMap<>();
>
> I don't think this is correct. "First Day" is the first day of the week and
> should not be plural.
The map contains several entries so I think the plural form is appropriate here.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/15736#discussion_r1396844057
