On Fri, 17 Nov 2023 08:13:05 GMT, Per Minborg <pminb...@openjdk.org> wrote:
>> src/java.base/share/classes/sun/util/cldr/CLDRCalendarDataProviderImpl.java >> line 48: >> >>> 46: public class CLDRCalendarDataProviderImpl extends >>> CalendarDataProviderImpl { >>> 47: >>> 48: private static final Map<String, Integer> firstDays = new >>> ConcurrentHashMap<>(); >> >> I don't think this is correct. "First Day" is the first day of the week and >> should not be plural. > > The map contains several entries so I think the plural form is appropriate > here. Current naming highlights the difference in values in this maps: `FIRST_DAY_OF_WEEK` vs `MINIMAL_DAYS_IN_FIRST_WEEK`. I like this approach. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/15736#discussion_r1396868339