Re: RFR: 8321248: ClassFile API ClassModel::verify is inconsistent with the rest of the API

[Adam Sotona]

On Wed, 6 Dec 2023 09:42:49 GMT, Adam Sotona <asot...@openjdk.org> wrote:

>> test/jdk/jdk/classfile/VerifierSelfTest.java line 62:
>> 
>>> 60: 
>>> 61:     @Test
>>> 62:     void testFailedDump() throws IOException {
>> 
>> Why is this removed?
>
> Dump (print) of the classfile to an optional log (Consumer&lt;String&gt; 
> argument) has been removed from the API.
> It was a relic from early phase of the ClassFile API development and it has 
> no use except for this test.
> This functionality can be replaced by explicit use of ClassPrinter.

I'll rename the test to "testFailed" and keep it without the "dump" part.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16947#discussion_r1417013768