On Mon, 4 Dec 2023 11:12:37 GMT, Adam Sotona <asot...@openjdk.org> wrote:
> ClassFile API `ClassModel::verify` accepts `ClassHierarchyResolver` as an > optional argument and does not respect > `ClassFile.ClassHierarchyResolverOption` of the actual context. > Parsing, building and transforming take options from the actual `ClassFile` > context and verification should follow the same API pattern. > > This patch removes `ClassModel::verify` methods and introduces new top level > methods: > > List<VerifyError> ClassFile::verify(ClassModel model); > List<VerifyError> ClassFile::verify(byte[] bytes); > List<VerifyError> ClassFile::verify(Path path); > > > Impact of the API change is minimal as the API has not been released yet. > > Please review. > > Thanks, > Adam This pull request has now been integrated. Changeset: 0217b5ac Author: Adam Sotona <asot...@openjdk.org> URL: https://git.openjdk.org/jdk/commit/0217b5ac8b25db96fce026ac027b18024e25a329 Stats: 94 lines in 11 files changed: 44 ins; 32 del; 18 mod 8321248: ClassFile API ClassModel::verify is inconsistent with the rest of the API Reviewed-by: jlahoda, mcimadamore ------------- PR: https://git.openjdk.org/jdk/pull/16947
