Re: RFR: 8294961: Convert java.base/java.lang.reflect.ProxyGenerator to use the Classfile API to generate proxy classes [v7]

[Adam Sotona]

On Fri, 5 Jan 2024 21:23:02 GMT, Mandy Chung <mch...@openjdk.org> wrote:

>> Adam Sotona has updated the pull request incrementally with one additional 
>> commit since the last revision:
>> 
>>   StackCounter fix
>
> src/java.base/share/classes/java/lang/reflect/ProxyGenerator.java line 739:
> 
>> 737:             var desc = new StringJoiner("", "(", ")" + 
>> returnType.descriptorString());
>> 738:             for (var pt : parameterTypes) {
>> 739:                 desc.add(pt.descriptorString());
> 
> Maybe worth refactor these as `ProxyMethod::toMethodTypeDescriptorString` 
> with the comment to explain why `MethodType::descriptorString` is not used.

I've decided to revert this custom optimization.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17121#discussion_r1444732383