On Mon, 8 Jan 2024 15:28:50 GMT, Adam Sotona <asot...@openjdk.org> wrote:
>> java.base java.lang.reflect.ProxyGenerator uses ASM to generate proxy >> classes. >> >> This patch converts it to use Classfile API. >> >> It is continuation of https://github.com/openjdk/jdk/pull/10991 >> >> Any comments and suggestions are welcome. >> >> Please review. >> >> Thank you, >> Adam > > Adam Sotona has updated the pull request incrementally with one additional > commit since the last revision: > > initialization of template entries by index The change looks fine. Please rerun the benchmark after JDK-8323183 is integrated. I made JDK-8294961 blocked by JDK-8323183 to ensure it goes in after it. src/java.base/share/classes/java/lang/reflect/ProxyGenerator.java line 144: > 142: //static template ClassModel holds pre-defined constant pool > entries > 143: //proxy transformed from the template shares the template > constant pool > 144: //each direct use of the template pool entry is significantly > faster Suggestion: // static template ClassModel holds pre-defined constant pool entries // proxy transformed from the template shares the template constant pool // each direct use of the template pool entry is significantly faster ------------- Marked as reviewed by mchung (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/17121#pullrequestreview-1811800119 PR Review Comment: https://git.openjdk.org/jdk/pull/17121#discussion_r1446484346
