On Tue, 23 Jan 2024 17:42:40 GMT, Aleksey Shipilev <sh...@openjdk.org> wrote:

>> Quan Anh Mai has updated the pull request incrementally with one additional 
>> commit since the last revision:
>> 
>>   ident
>
> src/java.base/share/classes/jdk/internal/misc/JitCompiler.java line 56:
> 
>> 54:      */
>> 55:     @IntrinsicCandidate
>> 56:     public static boolean isCompileConstant(boolean expr) {
> 
> Here and in other places: probably not `expr`, but just `val` or something?

I think of this as an expression that is always evaluated to the same value. 
The value itself is not interesting, it is the set of values that this 
expression can take that we are talking about.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17527#discussion_r1464085126

Reply via email to