On Wed, 6 Mar 2024 16:30:23 GMT, Matthias Baesken <mbaes...@openjdk.org> wrote:
>> We define the RESTARTABLE macro again and again at a lot of places in the
>> JDK native codebase. This could be centralized to avoid repeating it again
>> and again !
>
> Matthias Baesken has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Introduce windows jni_util_md.h
Looks good to me modulo a few license year things...
src/java.base/macosx/native/libnio/ch/KQueue.c line 2:
> 1: /*
> 2: * Copyright (c) 2012, 2024, Oracle and/or its affiliates. All rights
> reserved.
Here you only change the license year?
src/java.base/share/native/libjava/jni_util.h line 30:
> 28:
> 29: #include "jni.h"
> 30: #include "jni_util_md.h"
This file needs copyright year update
src/java.base/unix/native/libjava/childproc.h line 75:
> 73: #define FAIL_FILENO (STDERR_FILENO + 1)
> 74:
> 75: /* TODO: Refactor. */
Copyright year update missing.
src/java.base/unix/native/libnio/ch/nio_util.h line 34:
> 32: #include <sys/un.h>
> 33:
> 34: #define RESTARTABLE(_cmd, _result) do { \
Copyright year update
src/java.base/unix/native/libnio/fs/UnixFileSystem.c line 38:
> 36: #include "sun_nio_fs_UnixFileSystem.h"
> 37:
> 38: #define RESTARTABLE(_cmd, _result) do { \
Copyright year update
-------------
Changes requested by clanger (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/18132#pullrequestreview-1920355323
PR Review Comment: https://git.openjdk.org/jdk/pull/18132#discussion_r1514867262
PR Review Comment: https://git.openjdk.org/jdk/pull/18132#discussion_r1514873505
PR Review Comment: https://git.openjdk.org/jdk/pull/18132#discussion_r1514876266
PR Review Comment: https://git.openjdk.org/jdk/pull/18132#discussion_r1514878580
PR Review Comment: https://git.openjdk.org/jdk/pull/18132#discussion_r1514878995
