On Mon, 11 Mar 2024 12:27:08 GMT, Joachim Kern <jk...@openjdk.org> wrote:
>> Magnus Ihse Bursie has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Revert SEARCH_PATH changes
>
> make/autoconf/toolchain.m4 line 940:
>
>> 938: if test "x$OPENJDK_TARGET_OS" = xaix; then
>> 939: # Make sure we have the Open XL version of clang on AIX
>> 940: $ECHO "$CC_VERSION_OUTPUT" | $GREP "IBM Open XL C/C++ for AIX" >
>> /dev/null
>
> This does not work since $CC_VERSION_OUTPUT is unset. We need
> CC_VERSION_OUTPUT=`${XLC_TEST_PATH}ibm-clang++_r --version 2>&1 | $HEAD
> -n 1`
> before, as in the previous code some lines above which you removed.
Yeah, you are right. I confused it with CC_VERSION_STRING.
... duh.
Actually, that is what I should be using instead.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/18172#discussion_r1521667916
