On Tue, 2 Apr 2024 13:38:00 GMT, Daniel Fuchs <dfu...@openjdk.org> wrote:
>> Sean Coffey has updated the pull request incrementally with one additional >> commit since the last revision: >> >> incorporate testcase feedback from Daniel > > test/jdk/jdk/security/logging/RecursiveEventHelper.java line 56: > >> 54: // a recursive call (via EventHelper.isLoggingSecurity) back into >> 55: // logger API >> 56: EventHelper.isLoggingSecurity(); > > As an additional check you could set a static volatile boolean to true here > and double check that it's been set at the end of the main method, In fact it doesn't need to be volatile since it all happens in the main thread - but that's not a big issue. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/18534#discussion_r1548280946
