On Wed, 17 Apr 2024 14:05:28 GMT, Daniel Fuchs <dfu...@openjdk.org> wrote:
>> Tim Prinzing has updated the pull request incrementally with one additional >> commit since the last revision: >> >> test file local to test > > src/jdk.jfr/share/classes/jdk/jfr/internal/instrument/JDKEvents.java line 66: > >> 64: FileWriteEvent.class, >> 65: SocketReadEvent.class, >> 66: SocketWriteEvent.class, > > I'm guessing that this change which remove these two event classes is a > drive-by-cleanup that should actually have been done with some previous fix > in this area? > Just wanted to double check it was intended as it doesn't seem to be related > to file events. Yes, and I think it might be the cause for https://bugs.openjdk.org/browse/JDK-8329330 I will send out a PR to remove those separately (in 30 minutes) so a fix can be backported. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/18542#discussion_r1570887596
