On Thu, 18 Apr 2024 18:59:20 GMT, Tim Prinzing <tprinz...@openjdk.org> wrote:

>> Currently the JFR event FileForceEvent is generated by instrumenting the 
>> sun.nio.ch.FileChannelImpl class. This needs to be changed to use the newer 
>> mirror events with static methods.
>> 
>> Added the event at jdk.internal.event.FileForceEvent, and changed 
>> jdk.jfr.events.FileForceEvent to be a mirror event.
>> 
>> Updated FileChannelImpl to use the jdk internal event static methods, and 
>> removed the force() method from FileChannelImplInstrumentor.
>> 
>> Uses the existing tests.
>
> Tim Prinzing has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   IntelliJ trying to help

Marked as reviewed by egahlin (Reviewer).

src/jdk.jfr/share/classes/jdk/jfr/internal/instrument/JDKEvents.java line 46:

> 44: import jdk.jfr.events.FileWriteEvent;
> 45: import jdk.jfr.events.InitialSecurityPropertyEvent;
> 46: 

Unnecessary blank line added.

-------------

PR Review: https://git.openjdk.org/jdk/pull/18542#pullrequestreview-2009830262
PR Review Comment: https://git.openjdk.org/jdk/pull/18542#discussion_r1571335968

Reply via email to