On Fri, 3 May 2024 18:02:05 GMT, Naoto Sato <na...@openjdk.org> wrote:
>> Justin Lu has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - correct other test comment >> - reflect review > > src/java.base/share/classes/java/text/DecimalFormat.java line 2596: > >> 2594: exponent = -exponent; >> 2595: } >> 2596: sawExponent = true; > > I see you removed this assignment. I am wondering if we need this variable at > all. Should be updated in the latest commit, I had forgotten to remove the assignment as well as the check. As we always `break` once we parse the exponent, we have no need for the boolean flag. Thanks for the review! ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/19075#discussion_r1589587379
