On Mon, 6 May 2024 19:47:48 GMT, Axel Hauschulte <d...@openjdk.org> wrote:
>> Justin Lu has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Check both parse methods > > test/jdk/java/text/Format/DecimalFormat/LargeExponentsTest.java line 150: > >> 148: // Long.MIN_VALUE >> 149: Arguments.of("1.23E-9223372036854775808", 0.0) >> 150: ); > > I would suggest adding one more test case to the edge cases: > > Arguments.of("0.0123E-2147483648", 0.0) > > This will test the adjustment of the `digits.decimalAt` field for an exponent > that is within the range of integer, but due to the mantissa not being in its > standardized form an overflow will occure non the less. Right, that's a good test case to have, (which exposed a needed update in the implementation). ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/19075#discussion_r1591971646