On Thu, 2 May 2024 14:06:25 GMT, Hannes Wallnöfer <[email protected]> wrote:
>> Nizar Benalla has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> - Added some legacy modules that existed long before preview features
>> (they were incubating)
>> - Not checking elements enclosed withing a record
>> - Only check if the file is readable using `Files.isReadable`
>> - Dropped the use of `Files.exists` and `Files.isDirectory`
>> - Use `--add-modules` option now to resolve certain modules
>
> test/jdk/tools/sincechecker/SinceChecker.java line 106:
>
>> 104: public static void main(String[] args) throws Exception {
>> 105: if (args.length == 0) {
>> 106: throw new SkippedException("Test module not specified");
>
> I don't think `SkippedException` is the right exception to throw here, since
> invoking the method with a missing argument is probably a configuration error
> that shouldn't be ignored. Maybe `IllegalArgumentException` or just
> `RuntimeException`?
Fixed it, now throwing `IllegalArgumentException`.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/18934#discussion_r1590329254
