On Mon, 6 May 2024 18:07:06 GMT, Vicente Romero <vrom...@openjdk.org> wrote:
>> Adam Sotona has updated the pull request incrementally with one additional >> commit since the last revision: >> >> fixed tests > > src/java.base/share/classes/java/lang/classfile/Attributes.java line 28: > >> 26: >> 27: import java.lang.classfile.attribute.*; >> 28: import jdk.internal.classfile.impl.AbstractAttributeMapper.*; > > the second star import is probably unnecessary Thank you for the review! All the holders/mappers implementations are AbstractAttributeMapper inner classes. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/19006#discussion_r1591416140
