On Mon, 13 May 2024 07:51:19 GMT, Adam Sotona <[email protected]> wrote:
>> src/java.base/share/classes/java/lang/classfile/Attributes.java line 153:
>>
>>> 151:
>>> 152: /**
>>> 153: * {@return Attribute mapper for the {@code AnnotationDefault}
>>> attribute}
>>
>> Just wondering, can we change `{@code AnnotationDefault}` to `{@value
>> #NAME_ANNOTATION_DEFAULT}`, etc? This way, the names are still rendered as
>> code in Javadoc HTML, but they are generated with links to the constants,
>> and programmers will see these constants and prefer them over hardcoded
>> values.
>
> On the other side it is questionable if the attribute names should be exposed
> in the API. We provide corresponding mappers and attribute models. I don't
> see a case where user would need to use the attribute names directly.
Makes sense, we can always add these literals back if we do need them.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/19006#discussion_r1598368707
