On Wed, 8 May 2024 05:59:14 GMT, Jaikiran Pai <j...@openjdk.org> wrote:
>> Pavel Rappo has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Strengthen tests after 8330998 >> >> https://github.com/openjdk/jdk/pull/18996 now allows us to test >> Console IO better. > > src/java.base/share/classes/java/io/IO.java line 51: > >> 49: * console, terminates the line and then flushes that console. >> 50: * >> 51: * If {@code System.console()} returns {@code null}, throws {@code >> IOError}. > > Unlike, `java.io.Console` whose existing methods already throw `IOError`, > should these new methods on `java.io.IO` instead throw > `java.io.UncheckedIOException` instead of throwing `Error`s? As a result of several offline discussions, it was decided to throw `IOError` to better align with `java.io.Console`. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/19112#discussion_r1593711476
