On Tue, 21 May 2024 21:03:20 GMT, Matias Saavedra Silva <[email protected]>
wrote:
>> Ioi Lam has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> @calvinccheung comments
>
> test/lib/jdk/test/lib/cds/CDSAppTester.java line 147:
>
>> 145: }
>> 146:
>> 147: private OutputAnalyzer dumpStaticArchive() throws Exception {
>
> The code from 156 to 162 is repeated 3 times here, is it worth making another
> function for this?
Thanks for the suggestion. I've refactored the code a bit to make it easier to
write new execution modes (which will be needed in Leyden).
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/19256#discussion_r1610325214
