On Mon, 3 Jun 2024 10:30:03 GMT, Claes Redestad <redes...@openjdk.org> wrote:

>> Adam Sotona has updated the pull request incrementally with one additional 
>> commit since the last revision:
>> 
>>   added ProxyGenBench JMH micro benchmark
>
> test/micro/org/openjdk/bench/java/lang/reflect/Proxy/ProxyGenBench.java line 
> 66:
> 
>> 64:         ClassDesc tempDesc = 
>> ClassDesc.ofDescriptor(Interfaze.class.descriptorString());
>> 65:         loader = new ClsLoader();
>> 66:         clsMap = new HashMap<>(100);
> 
> Suggestion:
> 
>         clsMap = HashMap.newHashMap(100);

I've simplified it a lot. It uses a new `ClassLoader` instance for each proxy 
generation, instead of preparation of 100 different interfaces.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19410#discussion_r1624235034

Reply via email to