On Wed, 5 Jun 2024 03:54:46 GMT, Alexander Matveev <almat...@openjdk.org> wrote:

>> Alexey Semenyuk has updated the pull request incrementally with two 
>> additional commits since the last revision:
>> 
>>  - WixSourceConverter#applyTo should do what 
>> OverridableResource#saveToFile() does: create parent directory and replace 
>> output file if it exists.
>>  - Fix issue with overwriting custom l10n file in the resource directory. 
>> All WiX source files from the resource directory should be copied to 
>> jpackage work directory before running wxi tools. jpackage should not change 
>> files in the resource directory.
>
> src/jdk.jpackage/windows/classes/jdk/jpackage/internal/WixAppImageFragmentBuilder.java
>  line 157:
> 
>> 155: 
>> 156:     @Override
>> 157:     List<String> getLoggableWixFeatures() {
> 
> Maybe I am missing something, but is it used? I only see call to base class 
> `WixFragmentBuilder::getLoggableWixFeatures`.

`WixFragmentBuilder::getLoggableWixFeatures` is equivalent to:

new Function<WixFragmentBuilder, List<String>>() {
  public List<String> apply(WixFragmentBuilder obj) {
    return obj.getLoggableWixFeatures();
  }
}


An overridden WixAppImageFragmentBuilder#getLoggableWixFeatures() method will 
be called when WixAppImageFragmentBuilder instance is given.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19318#discussion_r1628020809

Reply via email to