On Tue, 4 Jun 2024 01:20:15 GMT, Alexander Matveev <almat...@openjdk.org> wrote:
> Do we need to handle default case for unknown wix type? In same cases you
> have default -> throw new IllegalArgumentException(); and in some you do not
> have.
Good catch. I'll update the code to make `switch(wixVersion) ...` expressions
consistent as follows:
switch (wixVersion) {
case Wix3 -> {}
case WiX4 -> {}
default -> throw new IllegalArgumentException();
}
-------------
PR Comment: https://git.openjdk.org/jdk/pull/19318#issuecomment-2150382290
