On Tue, 11 Jun 2024 18:11:55 GMT, Kevin Walls <kev...@openjdk.org> wrote:
>> jstatd is an RMI server application which monitors HotSpot VMs, and provides
>> an interface to the monitoring tool jstat, for use across a remote RMI
>> connection.
>>
>> RMI is not how modern applications communicate. It is an old transport with
>> long term security concerns, and configuration difficulties with firewalls.
>>
>> The jstatd tool should be removed. Deprecating and removing jstatd will not
>> affect usage of jstat for monitoring local VMs using the Attach API.
>
> Kevin Walls has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Remove annotations
Changes look okay now. Will you update the CSR to align with the PR?
src/jdk.jstatd/share/classes/sun/tools/jstatd/Jstatd.java line 84:
> 82:
> 83: System.err.println("Warning: jstatd is deprecated for removal in
> a future release.");
> 84:
I think we've put "WARNING" in caps in other usages.
-------------
Marked as reviewed by alanb (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/19658#pullrequestreview-2111296929
PR Review Comment: https://git.openjdk.org/jdk/pull/19658#discussion_r1635388247
