On Wed, 12 Jun 2024 14:06:39 GMT, Kevin Walls <kev...@openjdk.org> wrote:
>> For the same reason you should be able to just call `Subject.current` in the >> tests. I don't think you need the `SimpleStandard.useGetSubjectACC` property >> to toggle the testing of either old or replacement APIs as long as the test >> has runs in both SM allow and disallow (i.e., no SM prop set) modes. Would >> you agree Weijun? > > I thought there was a comment elsewhere suggesting using SM=allow to test > with Subject.getSubject() and Subject.current(), and when SM not allowed, to > only use Subject.current() ? > That was the reason for the property in the tests. Um, yes that was my comment :) Ok, let's leave the tests as is. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/19624#discussion_r1637054347
