On Thu, 13 Jun 2024 19:40:49 GMT, Chen Liang <[email protected]> wrote:
>> lingjun-cg has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 8333396: Performance regression of DecimalFormat.format
>
> src/java.base/share/classes/java/text/StringBuilderBufferProxy.java line 108:
>
>> 106: }
>> 107:
>> 108: class StringBuilderImpl implements StringBuilderBufferProxy {
>
> Avoid adding nested classes to interfaces, which are public. These classes
> are publicly accessible under reflection, and we want to avoid more of such
> occurrences. See
> https://bugs.openjdk.org/browse/JDK-8308040?focusedId=14581402&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-14581402
Thanks for your suggestion. I split this class into 2 classes: one is the
interface, the other is the factory class with package-private.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/19513#discussion_r1639179219
