On Wed, 19 Jun 2024 17:41:36 GMT, Maurizio Cimadamore <mcimadam...@openjdk.org> 
wrote:

>> Jorn Vernee has updated the pull request incrementally with one additional 
>> commit since the last revision:
>> 
>>   Update src/jdk.jdeps/share/classes/com/sun/tools/jnativescan/Main.java
>>   
>>   Co-authored-by: Maurizio Cimadamore 
>> <54672762+mcimadam...@users.noreply.github.com>
>
> src/jdk.jdeps/share/classes/com/sun/tools/jnativescan/JNativeScanTask.java 
> line 76:
> 
>> 74:             URI location = m.reference().location().orElseThrow();
>> 75:             Path path = Path.of(location);
>> 76:             checkRegularJar(path);
> 
> if exploded modules aren't supported (as discussed offline), maybe the error 
> message generated here should be more specific?

What do you suggest? Just a note in the error message that exploded 
modules/class paths are not supported?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19774#discussion_r1646643125

Reply via email to