On Wed, 9 Oct 2024 22:58:33 GMT, Serguei Spitsyn <[email protected]> wrote:
>> This fixes a problem in the VTMS (Virtual Thread Mount State) transition
>> frames hiding mechanism.
>> Please, see a fix description in the first comment.
>>
>> Testing:
>> - Verified with new test `vthread/CheckHiddenFrames`
>> - Mach5 tiers 1-6 are passed
>
> Serguei Spitsyn has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Disallow NotifyFramePop for
> enter/enter0/VirtualThread.run/VThreadContinuation.run
src/java.base/share/classes/java/lang/VirtualThread.java line 221:
> 219: vthread.notifyJvmtiStart();
> 220:
> 221: vthread.run(task);
This doesn't look right, it needs to use try-finally.
src/java.base/share/classes/java/lang/VirtualThread.java line 423:
> 421: }
> 422:
> 423: } finally {
This means an empty finally block, I assume you'll remove the try-finally here.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/21397#discussion_r1802558723
PR Review Comment: https://git.openjdk.org/jdk/pull/21397#discussion_r1802559933
