On Wed, 9 Oct 2024 22:58:33 GMT, Serguei Spitsyn <[email protected]> wrote:
>> This fixes a problem in the VTMS (Virtual Thread Mount State) transition
>> frames hiding mechanism.
>> Please, see a fix description in the first comment.
>>
>> Testing:
>> - Verified with new test `vthread/CheckHiddenFrames`
>> - Mach5 tiers 1-6 are passed
>
> Serguei Spitsyn has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Disallow NotifyFramePop for
> enter/enter0/VirtualThread.run/VThreadContinuation.run
src/java.base/share/classes/java/lang/VirtualThread.java line 219:
> 217: public void run() {
> 218: // notify JVMTI
> 219: vthread.notifyJvmtiStart();
The notifyJvmtiMount and notifyJvmtiUnmount (native) methods already have the
annotations. Is it really required on the caller too? I'm wondering if the
comment on JvmtiMountTransition needs to be expanded to explain this.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/21397#discussion_r1802569291
