On Wed, 12 Mar 2025 07:13:19 GMT, Jaikiran Pai <[email protected]> wrote:
>> Naoto Sato has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Reflects review comment
>
> test/jdk/java/io/Console/ConsolePromptTest.java line 77:
>
>> 75: var expect = Paths.get("/usr/bin/expect");
>> 76: if (!Files.exists(expect) || !Files.isExecutable(expect)) {
>> 77: System.out.println("'expect' command not found. Test
>> ignored.");
>
> Hello Naoto, I think throwing a `jtreg.SkippedException` might be better here
> so that it's clear that the test was skipped. There have been recent
> reporting improvements too which make it easier to notice such skipped tests.
Good point. Modified the piece (w/ some other minor changes)
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/23993#discussion_r1991925846
