On Wed, 26 Mar 2025 17:12:30 GMT, Naoto Sato <[email protected]> wrote:
>> test/jdk/java/io/IO/IO.java line 166:
>>
>>> 164: var file = Path.of(System.getProperty("test.src", "."),
>>> "Output.java")
>>> 165: .toAbsolutePath().toString();
>>> 166: var pb =
>>> ProcessTools.createTestJavaProcessBuilder("-Djdk.console=jdk.internal.le",
>>> "--enable-preview", file, mode);
>>
>> Have you looked into changing the test so that it runs twice, the second
>> with the jline provider?
>
> The child java process `Output.java` calls `System.console()`, so the
> launcher has to be run with `-Djdk.console=jdk.internal.le`, otherwise NPE is
> thrown in `Output.java`.
Ah okay, no console in the child process for this implementation.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/23993#discussion_r2016322402
