On Fri, 27 Jun 2025 04:59:58 GMT, Henry Jen <[email protected]> wrote:
>> Create a jar directly from the memory instead of real file, this should
>> reduce the I/O overhead which likely the reason for the time out.
>> The issue is not reproducible locally, and fails intermittently, so we
>> simply trying to reduce time needed.
>> The jar file created is verified manually running jtreg with retain=all.
>
> Henry Jen has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Adapt review feedbacks
test/jdk/tools/jlink/JLink20000Packages.java line 130:
> 128: /**
> 129: * Generate test class with main() does
> 130: * System.out.println("JLink20000PackagesTest started.");
The test currently does not use this `println` output for anything. It just
asserts on the exit code being zero.
Since the output is not observed, I think we should either simplify the test by
removing the `System.out.println`, or alternatively add a sanity check that the
process produces the expected output.
But since the test actually just wants to detect an image startup error, I'm
leaning towards this output being not really being needed so it could be
removed. The sanity check would just protected against issues in the test
itself I think, not help detect the bug this change fixed.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/25981#discussion_r2170900686
