On Fri, 27 Jun 2025 06:28:32 GMT, Eirik Bjørsnøs <eir...@openjdk.org> wrote:
>> Henry Jen has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Adapt review feedbacks
>
> test/jdk/tools/jlink/JLink20000Packages.java line 130:
>
>> 128: /**
>> 129: * Generate test class with main() does
>> 130: * System.out.println("JLink20000PackagesTest started.");
>
> The test currently does not use this `println` output for anything. It just
> asserts on the exit code being zero.
>
> Since the output is not observed, I think we should either simplify the test
> by removing the `System.out.println`, or alternatively add a sanity check
> that the process produces the expected output.
>
> But since the test actually just wants to detect an image startup error, I'm
> leaning towards this output being not really being needed so it could be
> removed. The sanity check would just protected against issues in the test
> itself I think, not help detect the bug this change fixed.
Right, it's just an evidence in the log to prove that the main is executed.
The test is derived from the `JLink100Modules.java` test and I don't see a
drawback for keeping it.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/25981#discussion_r2170916404
