On Wed, 29 Oct 2025 02:29:24 GMT, Alexey Semenyuk <[email protected]> wrote:
>> - Added JDK specific keys/values to Info.plist of embedded runtime. >> - Modified `setFakeRuntime()` not to include `bin` folder. By default it was >> always included, but generated embedded runtime by default does not have >> `bin` folder. As a result `CustomInfoPListTest` failed. >> - Updated `CustomInfoPListTest` to test Info.plist with `bin` folder. > > src/jdk.jpackage/macosx/classes/jdk/jpackage/internal/MacPackagingPipeline.java > line 363: > >> 361: final var app = env.app(); >> 362: >> 363: // We should use full runtime info plist for standalone runtime >> and for > > I guess the comment explains why jpackage should use the same info plist > template for a runtime if it has the "bin" subdirectory. But what is the > "full" runtime? "full" runtime info plist -> refers to info plist from standalone runtime. I will re-write it to: // We should use info plist from standalone runtime for embedded runtime // if embedded runtime contains "bin" folder, so embedded runtime // can act as standalone runtime. Standalone runtime always uses same // info plist which has "JavaVM" dictionary. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/28033#discussion_r2479674193
