On Wed, 29 Oct 2025 01:32:50 GMT, Alexander Matveev <[email protected]>
wrote:
> - Added JDK specific keys/values to Info.plist of embedded runtime.
> - Modified `setFakeRuntime()` not to include `bin` folder. By default it was
> always included, but generated embedded runtime by default does not have
> `bin` folder. As a result `CustomInfoPListTest` failed.
> - Updated `CustomInfoPListTest` to test Info.plist with `bin` folder.
test/jdk/tools/jpackage/macosx/CustomInfoPListTest.java line 189:
> 187: return defaultVerifier;
> 188: } else {
> 189: boolean includeBin =
> customPLists.contains(CustomPListType.EMBEDDED_RUNTIME_WITH_BIN);
`customPLists.contains(CustomPListType.EMBEDDED_RUNTIME_WITH_BIN)` puts
restrictions on what test cases can be executed with the external runtime that
has the "bin" subdirectory.
This should be a separate property of TestConfig class:
public record TestConfig(Set<CustomPListType> customPLists, boolean
runtimeWithBinDir)
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/28033#discussion_r2471643208
