On Mon, 3 Nov 2025 16:11:38 GMT, Fredrik Bredberg <[email protected]> wrote:
>> Patricio Chilano Mateo has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Improve comment and assert msg
>
> src/hotspot/cpu/ppc/macroAssembler_ppc.cpp line 762:
>
>> 760: load_const_optimized(bad, 0xbad0101babe00000);
>> 761: for (uint32_t i = 1; i < (sizeof(regs) / sizeof(Register)); i++) {
>> 762: addi(regs[i], regs[0], regs[i]->encoding());
>
> Guess it's a question for @reinrich, but why set up `bad = regs[0]` and then
> still use `regs[0]` instead of `bad`?
> I think using `bad` would make the code easier to understand than using
> `regs[0]`.
> Suggestion:
>
> addi(regs[i], bad, regs[i]->encoding());
Thanks for looking at the ppc part @fbredber
Your suggestion is good. I think the loop should be reversed too. Then the addi
after it can be removed.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/27802#discussion_r2487475002
