On Mon, 3 Nov 2025 16:22:13 GMT, Fredrik Bredberg <[email protected]> wrote:
> A truly useful enhancement! Just had a few questions / suggestions. > Thanks for the review Fred! > src/hotspot/share/interpreter/linkResolver.cpp line 1689: > >> 1687: EXCEPTION_MARK; >> 1688: CallInfo info; >> 1689: resolve_static_call(info, link_info, ClassInitMode::dont_init, >> THREAD); > > Couldn't you just do `CHECK_AND_CLEAR_NULL` and skip the following `if > (HAS_PENDING_EXCEPTION)` statement? > > Suggestion: > > resolve_static_call(info, link_info, ClassInitMode::dont_init, > CHECK_AND_CLEAR_NULL); > > I see the same in functions both above and below this one, is there any > reason for this? Yes, I agree. I see there are a couple of instances of this pattern in this file as you point out, so if you are okay I’d prefer to file a separate bug to clean them all up together. ------------- PR Comment: https://git.openjdk.org/jdk/pull/27802#issuecomment-3482021139 PR Review Comment: https://git.openjdk.org/jdk/pull/27802#discussion_r2487524814
