On Tue, 18 Nov 2025 01:27:33 GMT, Alexander Matveev <[email protected]>
wrote:
>> - Added JDK specific keys/values to Info.plist of embedded runtime.
>> - Modified `setFakeRuntime()` not to include `bin` folder. By default it was
>> always included, but generated embedded runtime by default does not have
>> `bin` folder. As a result `CustomInfoPListTest` failed.
>> - Updated `CustomInfoPListTest` to test Info.plist with `bin` folder.
>
> Alexander Matveev has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8363980: [macos] Add JDK specific keys/values to Info.plist of embedded
> runtime [v4]
test/jdk/tools/jpackage/helpers/jdk/jpackage/test/JPackageCommand.java line
1229:
> 1227: if (!Files.isDirectory(appLayout.runtimeDirectory())) {
> 1228: return;
> 1229: }
A missing runtime directory is not a regular situation.
In such a case, (I believe `AppImagePackageTest.testEmpty()` is the only one)
test should explicitly exclude this assert. See how
`AppImagePackageTest.testEmpty()` excludes the `RUNTIME_DIRECTORY` and other
asserts.
I suggest removing the test for the runtime directory from the assert body and
adding `MAC_RUNTIME_PLIST_JDK_KEY` assert to the list of excluded asserts in
the `AppImagePackageTest.testEmpty()` test.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/28033#discussion_r2536064398
