On Mon, 17 Nov 2025 20:42:11 GMT, Ana Maria Mihalceanu <[email protected]> wrote:

>> src/jdk.jlink/share/man/jlink.md line 68:
>> 
>>> 66: 
>>> 67: `-c=zip-[0-9]` or `--compress=zip-[0-9]`
>>> 68: :   Enable compression of resources. The accepted values are:
>> 
>> All good for `--compress`. Can you double check that `-c` actually works?
>
> Thank you so much for spotting this! `-c` does not work and `jlink --help` 
> command does not list it either.  Will remove it from this part.

I suspect something has got messed up in the CLI parsing. `-c` should be the 
short form of `--compress`. At this time, `-c`, with no params, is the 
equivalent of `--compress 2` so we get a confusing warning. As we've found, 
providing parameters to the short form doesn't seem to work.  So I think we 
need to dig into this more.

Also a comment on the "Deprecated values to be removed in a future release" 
section. This could easier to read that zip-0 and zip-6 are being deprecated. 
Instead of "Equivalent to zip-0", then maybe we should say "Use zip-0 instead".

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/28359#discussion_r2536671831

Reply via email to