On Thu, 20 Nov 2025 12:12:12 GMT, Jaikiran Pai <[email protected]> wrote:
>> Ana Maria Mihalceanu has updated the pull request incrementally with two >> additional commits since the last revision: >> >> - Remove extra line. >> - Align behavior of compression levels to the input received and sync >> help+documentation messages. > > src/jdk.jlink/share/man/jlink.md line 67: > >> 65: : Link service provider modules and their dependencies. >> 66: >> 67: `-c zip-[0-9]` or `--compress=zip-[0-9]` > > Nit - the use of square brackets is usually meant to imply "optional". Here > it is mandatory to specify a digit between 0 and 9 following the "zip-" text. > Perhaps using angular bracket would be better? > > -c zip-<0-9> or --compress=zip-<0-9> Good point. Thank you. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/28359#discussion_r2545978005
