On Sat, 6 Dec 2025 19:54:28 GMT, Joe Darcy <[email protected]> wrote:
>> Patrick Strawderman has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Add coverage for other factory methods: noneOf, of, etc > > Hmm. Catching up on reviews, should the behavior change here get a CSR? More > broader, should there be an implSpec change under a follow-up bug and CSR > that requires this behavior? > @jddarcy Seems reasonable! Chasing down the super-implementation, > [Set::spliterator()](https://docs.oracle.com/en/java/javase/25/docs/api/java.base/java/util/Set.html#spliterator()) > states that overloads should report their characteristics (even if the > documentation linked does seem to unnecessarily convolutedly state which > characteristics the default implementation provides). I can open up a new > Issue and handle the CSR-bits if @kilink doesn't mind? Sounds good to me, thanks! Also, apologies, it hadn't occurred to me that this would require an update to the javadocs. The existing docs do specify that the Iterator returns elements in their natural order, and that null is not permitted, so one could say that it's implied that the spliterator would also have those characteristics. But I do see now that you pointed it out that Set indicates implementations should document any additional characteristics. ------------- PR Comment: https://git.openjdk.org/jdk/pull/28568#issuecomment-3621405033
