On Thu, 18 Dec 2025 07:30:36 GMT, Alan Bateman <[email protected]> wrote:
>> Chen Liang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Some omissions
>
> test/jdk/java/lang/invoke/DropLookupModeTest.java line 158:
>
>> 156: Integer.MIN_VALUE,
>> 157: })
>> 158: public void testBadInput(Integer modeToDrop) {
>
> The ValueSource produces ints but the parameter to testBadInput is Integer.
> The original data provider test used Integer too so I assume this was just
> the conversion.
Looks like this luckily works because junit boxes all ValueSource values, which
don't have to be unboxed when passed here. But yes, this method should take an
int instead.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/28879#discussion_r2635736836
