On Wed, 28 Jan 2026 10:02:53 GMT, Andrew Haley <[email protected]> wrote:
> > The IR test framework is better at determining that by testing the right IR > > nodes are generated - and they get run as part of the existing HotSpot test > > suite. > > But as a reviewer I'm not looking at the IR at all, but at the performance. That's a good point. Where i have concerns is introducing a very large set of vector micro benchmarks in bulk or over time in to the mainline under the `test/micro` directory. Further, i am not very happy with the way we generate the vector API benchmarks by leaning on the unit test harness (of which i am also not so happy about). A better approach might be to generate a benchmark on demand for an operation so it can be verified if needed. I think to do this properly we need to invest some resources, which are limited, at least from my side, and so would require some adjustment in priorities. ------------- PR Comment: https://git.openjdk.org/jdk/pull/28693#issuecomment-3812696618
