> Please review this PR which converts the JDBC TestNG tests to use JUnit. > > This is mainly done using the automated tool in > https://github.com/openjdk/jdk/commit/0cec3097aec02e72ccb6ebbf0b2b046220578d1b, > with some manual follow up commits. The testng folder is migrated to junit > with the TEST.properties updated as well. Most changes are annotation updates > and switching from testNG imports to JUnit. I decided to simplify cases of > `BaseTest.trueFalse()` to use booleans in a `ValueSource` directly in > https://github.com/openjdk/jdk/commit/757e7966666d39748db2912b32ccf8b1df18bd62. > > Framework test stats before: > 680 = 680 TestNG + 0 JUnit > > Framework test stats after: > 680 = 0 TestNG + 680 JUnit
Justin Lu has updated the pull request incrementally with one additional commit since the last revision: Another occurrence of eof newline required ------------- Changes: - all: https://git.openjdk.org/jdk/pull/29354/files - new: https://git.openjdk.org/jdk/pull/29354/files/e80ad61a..18b55f57 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=29354&range=03 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=29354&range=02-03 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk/pull/29354.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/29354/head:pull/29354 PR: https://git.openjdk.org/jdk/pull/29354
