On Wed, 28 Jan 2026 23:29:43 GMT, Justin Lu <[email protected]> wrote:
>> Please review this PR which converts the JDBC TestNG tests to use JUnit. >> >> This is mainly done using the automated tool in >> https://github.com/openjdk/jdk/commit/0cec3097aec02e72ccb6ebbf0b2b046220578d1b, >> with some manual follow up commits. The testng folder is migrated to junit >> with the TEST.properties updated as well. Most changes are annotation >> updates and switching from testNG imports to JUnit. I decided to simplify >> cases of `BaseTest.trueFalse()` to use booleans in a `ValueSource` directly >> in >> https://github.com/openjdk/jdk/commit/757e7966666d39748db2912b32ccf8b1df18bd62. >> >> Framework test stats before: >> 680 = 680 TestNG + 0 JUnit >> >> Framework test stats after: >> 680 = 0 TestNG + 680 JUnit > > Justin Lu has updated the pull request incrementally with one additional > commit since the last revision: > > Another occurrence of eof newline required Hi Justin, Thank you for taking this on. Overall the changes look fine. Please run the the tests across all of the mach5 platforms so that we get some extra sanity ------------- Marked as reviewed by lancea (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/29354#pullrequestreview-3724038853
