On Tue, 10 Feb 2026 05:57:47 GMT, Jatin Bhateja <[email protected]> wrote:

>> Added the missing definition of 'swapIfNeeded' in X-Vector.java.template 
>> 
>> JBS : [JDK-8377355](https://bugs.openjdk.org/browse/JDK-8377355)
>
> src/jdk.incubator.vector/share/classes/jdk/incubator/vector/X-Vector.java.template
>  line 5396:
> 
>> 5394:     }
>> 5395: 
>> 5396:     @Override
> 
> For sake of uniformity you should add /*package-private*/ comment over newly 
> defined swapIfNeeded method.

I think not having that is fine, the classes already have many package-private 
method without such a comment.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/29616#discussion_r2785991455

Reply via email to